Topic: Unable to hide notes on mobile

Posted under Site Bug Reports & Feature Requests

This topic has been locked.

Today I noticed that I can no longer hide translation notes by clicking outside of them anymore. I don't know if this is a bug or something intentionally changed, but if there is any way to fix it I would like to know so I don't have the boxes cover the image. I know I can technically open the image itself, but I feel like it's very inconvenient to do all the time.

Updated by Versperus

Watsit

Privileged

I can't hide them on desktop either. Clicking on the image would normally toggle the notes, but it doesn't do anything now.

honestly, this was really, really annoying on mobile and I'm glad it's gone, since on mobile you have to tap to change the element your "mouse" is hovering over it meant that you had to tap the image to hide the note popup and then tap again to unhide all the clickboxes and then tap a third time to select the note you wanted to show, and any misclicks add another two.

dba_afish said:
honestly, this was really, really annoying on mobile and I'm glad it's gone, since on mobile you have to tap to change the element your "mouse" is hovering over it meant that you had to tap the image to hide the note popup and then tap again to unhide all the clickboxes and then tap a third time to select the note you wanted to show, and any misclicks add another two.

Except, now there's no way to view the artwork in a way that's not covered in white rectangles.

lendrimujina said:
Except, now there's no way to view the artwork in a way that's not covered in white rectangles.

there's a download button

dba_afish said:
there's a download button

Yes, but that's not the most convenient thing. Artists don't intend their work to be viewed covered in white rectangles, and viewers likely don't want to view it that way either. Viewing it the intended way should be convenient.

crocogator said:
Yes, but that's not the most convenient thing. Artists don't intend their work to be viewed covered in white rectangles, and viewers likely don't want to view it that way either. Viewing it the intended way should be convenient.

notes are primarily used to translate text, so, in a grand majority of instances where notes appear on the post, the art wouldn't be able to be appreciated at all if the notes weren't there.

the only other legitimate use is when a typo is so bad the sentence is difficult or impossible to parse without a note to correct it (like forgetting to include "not" in a sentence) or _maybe_ links to other posts/webpages when they appear in the background.

if a post contains notes that are overall superfluous/detrimental to the art, they should not be there at all.

Watsit

Privileged

dba_afish said:
notes are primarily used to translate text, so, in a grand majority of instances where notes appear on the post, the art wouldn't be able to be appreciated at all if the notes weren't there.

Except by people who can read the language and the note boxes get in the way. Or those who, after reading the translation, would like to see the art in full without worrying about what it says.

And there's plenty of posts like these:
post #5380959 post #5378608 post #5267781
where notes are used to identify who's who, which isn't required to enjoy the image but is still appreciated by those who care. Or like
post #2602438
where it's used to identify an image in an image, providing a link to the original.

watsit said:
Except by people who can read the language and the note boxes get in the way. Or those who, after reading the translation, would like to see the art in full without worrying about what it says.

I'd still say that the download button is perfectly functional for this.

watsit said:
And there's plenty of posts like these:
post #5380959 post #5378608 post #5267781
where notes are used to identify who's who, which isn't required to enjoy the image but is still appreciated by those who care. Or like

this is actually a case where I could see being able quickly toggle the notes on and off having usd, where the having the work annotated is simultaneously useful and annoying, since the notes' main visible element do constantly obfuscate the content but being able to use them still has value... probably better to have a function that isn't just clicking on the image to toggle them, though, since that has other negatives.

also, notes by default might ought to be made at least a bit less obtrusive.

Watsit

Privileged

dba_afish said:
I'd still say that the download button is perfectly functional for this.

Unless it's a large image and you rely on the "Fit (Horizontal)" option, as I do to only need to scroll up and down as I'm reading. Larger images can otherwise require scrolling left and right as well as up and down, which is very inconvenient and distracting. It also means you don't have the tag list or anything else when viewing the image without notes, The note boxes can be obscuring details worth tagging too (even if the boxes are made less obtrusive, there's only so much you can do since the point is to visibly indicate they're there and be able to move/resize them). Switching tabs to "toggle" notes is also much less convenient than simply clicking the image.

If it's that much of an issue for some people accidentally toggling the notes, a user or theme setting to hide/show notes via clicking or tapping the image would be helpful.

watsit said:
If it's that much of an issue for some people accidentally toggling the notes, a user or theme setting to hide/show notes via clicking or tapping the image would be helpful.

I think just having a toggle button under the image would be best.

Funny, I asked about this in the general bug report thread with no response... Anyway, checked with the dev tools:

The image has an onclick handler calling the toggle_all function in webpack://Danbooru/app/javascript/src/javascripts/notes.js:190 which toggles the visibility style of the #note-container, so obviously the function was not intentionally removed.

But when actually clicking on the image, the visibility style is toggled a second time from Blacklist.init_reveal_on_click in webpack://Danbooru/app/javascript/src/javascripts/blacklists.js:90 - this was added by https://github.com/e621ng/e621ng/commit/0ecee07433600f9a2443ab62877c3cee8e762e74

So, looks like a genuine bug.

Please keep things in the appropriate stickied forum.
The developer has been notified of the issue yesterday.